Add columns for task params#95
Merged
Merged
Conversation
jacob720
force-pushed
the
52_add_columns_for_task_params
branch
from
1db7509 to
d305912
Compare
jacob720
force-pushed
the
52_add_columns_for_task_params
branch
from
d305912 to
0308cbd
Compare
…ghtSource/atlas into 52_add_columns_for_task_params
jacob720
force-pushed
the
52_add_columns_for_task_params
branch
from
00a073b to
bd878a5
Compare
Collaborator
Author
|
I think the huge diff is from me accidentally linting a generated file, happy to change that back |
DominicOram
approved these changes
Jun 30, 2026
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks. One comment in code, take it or leave it.
Comment on lines
+62
to
+69
| experiment: { | ||
| name: exp.experiment.name, | ||
| experiment_definition: exp.experiment | ||
| .experimentDefinition as ExperimentDefinition, | ||
| sample: exp.experiment.sample as Sample, | ||
| instrument_session: | ||
| exp.experiment.sample.instrumentSessions?.[0]?.instrumentSessionReference?.toLowerCase() ?? | ||
| "", |
Contributor
There was a problem hiding this comment.
Could: I think it would be good to have this conversion as a seperate, well named function. Maybe with some unit tests to confirm the logic on the session?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52
Requires DiamondLightSource/daq-queuing-service#57