Skip to content

Added values used by Murfey's email notification workflow to the message sent back from cryolo#136

Merged
stephen-riggs merged 4 commits intomainfrom
email-notifications-feedback
Mar 13, 2025
Merged

Added values used by Murfey's email notification workflow to the message sent back from cryolo#136
stephen-riggs merged 4 commits intomainfrom
email-notifications-feedback

Conversation

@tieneupin
Copy link
Contributor

The PR at DiamondLightSource/python-murfey#484 looks for parameters named particle_count, astigmatism, defocus, and resolution in the messages received by the feedback queue, and these values appear to be calculated as part of the CTFFind service, but are not passed on back to Murfey.

This PR adds those values to the message sent by the Cryolo service back to Murfey.

@tieneupin tieneupin self-assigned this Mar 12, 2025
@tieneupin tieneupin added the enhancement New feature or request label Mar 12, 2025
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (e0a7703) to head (56dfc10).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   78.04%   78.04%           
=======================================
  Files          52       52           
  Lines        6787     6787           
  Branches      951      951           
=======================================
  Hits         5297     5297           
  Misses       1040     1040           
  Partials      450      450           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin requested a review from stephen-riggs March 12, 2025 17:04
@stephen-riggs stephen-riggs merged commit dcbf18c into main Mar 13, 2025
12 checks passed
@stephen-riggs stephen-riggs deleted the email-notifications-feedback branch March 13, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants