Added image registration utility functions and refactored image processing module#245
Merged
Added image registration utility functions and refactored image processing module#245
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 83.78% 84.12% +0.33%
==========================================
Files 66 68 +2
Lines 8431 8925 +494
Branches 1138 1231 +93
==========================================
+ Hits 7064 7508 +444
- Misses 939 963 +24
- Partials 428 454 +26 🚀 New features to boost your workflow:
|
tieneupin
force-pushed
the
add-correlative-utils
branch
from
f26ff10 to
7b8f547
Compare
…ith its helper functions
…e dealing with fractional values between 0-1 instead of percentages between 0-100
…dated comments and docstrings
…ule in 'test_utils'
…updated documentation
…e features for tests
stephen-riggs
approved these changes
Mar 13, 2026
Contributor
stephen-riggs
left a comment
stephen-riggs
left a comment
There was a problem hiding this comment.
The code looks good to me. I don't know enough about the alignment methods used to comment on them though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces another image registration function,
align_images_using_orb, that makes use of edge detection combined with ORB feature detection. It's intended to be used primarily with correlative workflows to align images of FIB-milled samples using the milled sites as features to estimate the transformation matrix with.Additionally, the
clem_array_functionsmodule has been renamed toimage_processingsince these functions can be used for most image processing use cases.Much of the bulk of this PR comes from the introduction of the tests and test utility functions needed to test the new image registration function.