Skip to content

Rationalize models #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterC-DLS merged 3 commits into from
Dec 15, 2025
Merged

Rationalize models #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4386fe
Rationalize models
PeterC-DLS Sep 25, 2025
8087ad3
Update code docs and error messages
PeterC-DLS Dec 15, 2025
e16645d
Remove unnecessary linter directive
PeterC-DLS Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/component/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"websocket": "^1.0.35"
},
"peerDependencies": {
"@h5web/lib": "14.0.1",
"@h5web/lib": "^15.0.0",
"@react-three/drei": "^9.122.0",
"@react-three/fiber": "^8.17.0",
"ndarray": "^1.0.19",
Expand Down
4 changes: 2 additions & 2 deletions client/component/src/AxialSelectionConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function AxialSelectionConfig(props: AxialSelectionConfigProps) {
return selection.dimension === 0 ? (
<Fragment key="axis x">
<XInput
key={`XInput${selection.vStart.x}`}
key={`XInput${selection._vStart.x}`}
selection={selection}
updateSelection={updateSelection}
disabled={disabled}
Expand All @@ -52,7 +52,7 @@ function AxialSelectionConfig(props: AxialSelectionConfigProps) {
) : (
<Fragment key="axis y">
<YInput
key={`YInput${selection.vStart.y}`}
key={`YInput${selection._vStart.y}`}
selection={selection}
updateSelection={updateSelection}
disabled={disabled}
Expand Down
Loading