Skip to content

Allow selection types to be specify for a plot with a maximum number#209

Merged
PeterC-DLS merged 3 commits into
v1.0from
allow-selection-types-customization
Oct 31, 2025
Merged

Allow selection types to be specify for a plot with a maximum number#209
PeterC-DLS merged 3 commits into
v1.0from
allow-selection-types-customization

Conversation

@PeterC-DLS

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread client/component/src/PlotCustomizationContext.tsx Outdated
Comment thread client/component/src/PlotCustomizationContext.tsx Outdated
Comment thread client/component/src/PlotToolbar.tsx Outdated

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterC-DLS PeterC-DLS merged commit 3aacc70 into v1.0 Oct 31, 2025
2 checks passed
@PeterC-DLS PeterC-DLS deleted the allow-selection-types-customization branch October 31, 2025 13:56
github-merge-queue Bot pushed a commit that referenced this pull request Nov 3, 2025
* Add pnpm-lock file for release

* Use new token

Also add vite flag to empty external output directory

* Allow downstream to avoid invalid hook issues with multiple React versions

Use peerDependencies in the component package to allow downstream to access external packages and configure rollup. Also update package version, pnpm lock
and react version in lint config

* Add new selections event listener 

Export it and selections hook, replace broadcast arguments with dragging and flip some values. Also add example code

* Add host and port arguments to simple demo (#203)

For the example client, use vite environment variables for host and port in development mode;
in production, use the client's window and set server default to port 80; with demo, use port 8000

* Update version for patch release (#204)

* Configure npm workflow for trusted publishing (#212)

* Allow selection types to be specify for a plot with a maximum number (#209)

Also remove selection dropdown when there's no choices and hide select region button

* Defer histogram calculation until required in dialog (#210)

* Remove extraneous separator from toolbar when no selection types are allowed

* Update version for patch release

Also add pnpm script to bump version by patch level

* Update version in root package.json

* Update actions to use Node 24 as that has npm cli 11

This version supports trusted publishing
github-merge-queue Bot pushed a commit that referenced this pull request Jan 14, 2026
* Add pnpm-lock file for release

* Use new token

Also add vite flag to empty external output directory

* Allow downstream to avoid invalid hook issues with multiple React versions

Use peerDependencies in the component package to allow downstream to access external packages and configure rollup. Also update package version, pnpm lock
and react version in lint config

* Add new selections event listener 

Export it and selections hook, replace broadcast arguments with dragging and flip some values. Also add example code

* Add host and port arguments to simple demo (#203)

For the example client, use vite environment variables for host and port in development mode;
in production, use the client's window and set server default to port 80; with demo, use port 8000

* Update version for patch release (#204)

* Configure npm workflow for trusted publishing (#212)

* Allow selection types to be specify for a plot with a maximum number (#209)

Also remove selection dropdown when there's no choices and hide select region button

* Defer histogram calculation until required in dialog (#210)

* Remove extraneous separator from toolbar when no selection types are allowed

* Update version for patch release

Also add pnpm script to bump version by patch level

* Update version in root package.json

* Update actions to use Node 24 as that has npm cli 11

This version supports trusted publishing

* Update CI actions and package metadata

Also update CI to use Node 24 and Python 3.12 and tweak comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants