Skip to content

enabling errors for gpu-disabled devices#698

Merged
dkazanc merged 10 commits intomainfrom
cli_no_gpu
Apr 1, 2026
Merged

enabling errors for gpu-disabled devices#698
dkazanc merged 10 commits intomainfrom
cli_no_gpu

Conversation

@dkazanc
Copy link
Copy Markdown
Collaborator

@dkazanc dkazanc commented Mar 30, 2026

Fixes issue

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • I have added the user-release-note label in order to include this PR in the "Notable
    Changes for Users" section in release notes

@dkazanc dkazanc changed the title work on enabling errors for gpu-disabled devices enabling errors for gpu-disabled devices Mar 30, 2026
@dkazanc dkazanc marked this pull request as ready for review March 30, 2026 12:05
@dkazanc
Copy link
Copy Markdown
Collaborator Author

dkazanc commented Mar 30, 2026

@yousefmoazzam I managed to get to a device without GPU to test this. I discovered that it wasn't actually possible to run CPU-only pipelines due to a couple of conditions that are fixed now in this PR. I then also discovered that by this condition in wrappers we usually pick up earlier if the pipeline contains GPU methods when running on the CPU-only device:

        if self.is_gpu and not gpu_enabled:
            raise ValueError("GPU is not available, please use only CPU methods") 

So I removed my changes on checking if pipeline is a GPU or not as it comes AFTER the pipeline generation step in CLI.
And I moved the paganin method import in the sweep runner to avoid the issue we discussed.

@dkazanc dkazanc requested a review from yousefmoazzam March 30, 2026 12:11
Copy link
Copy Markdown
Collaborator

@yousefmoazzam yousefmoazzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only one suggestion, feel free to take it or leave it!

Since the iris CI has been pretty bad lately, I'll also just note to make sure tests pass locally.

@dkazanc dkazanc merged commit 856733c into main Apr 1, 2026
1 of 3 checks passed
@dkazanc dkazanc deleted the cli_no_gpu branch April 1, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants