Conversation
|
@yousefmoazzam I managed to get to a device without GPU to test this. I discovered that it wasn't actually possible to run CPU-only pipelines due to a couple of conditions that are fixed now in this PR. I then also discovered that by this condition in wrappers we usually pick up earlier if the pipeline contains GPU methods when running on the CPU-only device: So I removed my changes on checking if pipeline is a GPU or not as it comes AFTER the pipeline generation step in CLI. |
yousefmoazzam
left a comment
There was a problem hiding this comment.
Looks good to me, only one suggestion, feel free to take it or leave it!
Since the iris CI has been pretty bad lately, I'll also just note to make sure tests pass locally.
Fixes issue
Checklist
user-release-notelabel in order to include this PR in the "NotableChanges for Users" section in release notes