Merged
Conversation
Bumps the actions group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [actions/download-artifact](https://github.com/actions/download-artifact). Updates `actions/upload-artifact` from 5 to 6 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v5...v6) Updates `actions/download-artifact` from 6 to 7 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/download-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com>
Fix flaky test
…ons/actions-c2e7f7cad0 chore: bump the actions group with 2 updates
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 96.28% 96.45% +0.16%
==========================================
Files 12 13 +1
Lines 485 508 +23
==========================================
+ Hits 467 490 +23
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
noemifrisina
requested changes
Mar 11, 2026
Collaborator
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Works nicely, thanks. A couple of things...
Must: we need an attribute in the UI where the value from this combo box is saved so that we'll be able to pass it to the parameters when needed
…ize into general_utils file
noemifrisina
requested changes
Mar 12, 2026
Collaborator
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Thanks, just a couple small things, sorry.
|
|
||
|
|
||
| class ApertureOptions(StrEnum): | ||
| um_20 = "20um" |
Collaborator
There was a problem hiding this comment.
Should: enum names are usually all caps
tests/gui/test_eh2_ui.py
Outdated
| @pytest.mark.parametrize( | ||
| "options,index", [("20um", 0), ("40um", 1), ("100um", 2), ("3000um", 3)] | ||
| ) | ||
| def test_dropdown_update(mock_eh2_gui, options, index): |
Collaborator
There was a problem hiding this comment.
Nit: options is not super obvious as a name, "aperture" or "choice" would work better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on #33
Yet to pass the output onwards but can read the selected output as a string in 'read_aperture_dropdown()' method (tested in unit tests)