Conversation
…ize into general_utils file
…variable names properly
…ize into general_utils file
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 96.45% 96.40% -0.06%
==========================================
Files 13 13
Lines 508 500 -8
==========================================
- Hits 490 482 -8
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Matt-Carre
changed the title
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Looks good, thank you! Just a few small comments
| self.test_btn1 = self._create_button("Run zebra", self.run_zebra) | ||
|
|
||
| self.test_btn2 = self._create_button("Run panda", self.run_panda) | ||
| self.test_btn2 = self._create_button("Run Plan", self.run_panda) |
There was a problem hiding this comment.
Should: rename this to run_btn or at least something more specific as we don't have two test buttons anymore
| self.appendOutput("Run zebra plan") | ||
| self.appendOutput(f"With parameters: {params}") | ||
|
|
||
| def run_panda(self): |
There was a problem hiding this comment.
Should: rename this function too
| self.client.run_plan("run_panda_test", params) | ||
| self.appendOutput("Run panda plan") | ||
| self.client.run_plan("run_serial_from_panda", params) | ||
| self.appendOutput("Run serial from panda") |
There was a problem hiding this comment.
| self.appendOutput("Run serial from panda") | |
| self.appendOutput("Start serial collection with the panda") |
FETCH_HEAD
Outdated
There was a problem hiding this comment.
Must: remove this file
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Just one more thing...
| self.appendOutput(f"With parameters: {params}") | ||
|
|
||
| def run_panda(self): | ||
| def run_btn(self): |
There was a problem hiding this comment.
Should: maybe give it a name that indicates what we're running?
There was a problem hiding this comment.
Also, comment on the button name attribute still stands - anyone who looks at this in the future should know what that button is without having to dig...
There was a problem hiding this comment.
Good plans - shall do!
2 participants
Closes #39
Should be able to call the discoverable i19 main setup plan.