Skip to content

Allow visit completion to run more asynchronously#543

Merged
d-j-hatton merged 10 commits intomainfrom
better-visit-complete
Mar 31, 2025
Merged

Allow visit completion to run more asynchronously#543
d-j-hatton merged 10 commits intomainfrom
better-visit-complete

Conversation

@d-j-hatton
Copy link
Contributor

The multigrid controller should now be able to handle most of the process of cleaning up all associated threads. Thread completion requests are performed by setting flags and not explicitly waiting for joins. Callbacks are then used to notify of thread completion. (RSyncer threads are slightly more complicated because they have to perform file removal after completing.)

On completion of all associated threads the multigrid controller will mark itself as dormant. When new multigrid controllers are added dormant controllers are checked for and removed along with the associated Murfey session data. This could also possibly be triggered when the controller marks itself as dormant for a quicker cleanup?

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 17.64706% with 56 lines in your changes missing coverage. Please review.

Project coverage is 29.93%. Comparing base (28a47f7) to head (3c44eb9).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   28.97%   29.93%   +0.96%     
==========================================
  Files          80       80              
  Lines       10309    10907     +598     
  Branches     1363     1450      +87     
==========================================
+ Hits         2987     3265     +278     
- Misses       7221     7533     +312     
- Partials      101      109       +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-j-hatton
Copy link
Contributor Author

Attempts to resolve #530

@d-j-hatton
Copy link
Contributor Author

Need to check that controller is dormant before deleting session from database

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, but other than that, no obvious errors! 👍

@d-j-hatton d-j-hatton merged commit 84770ff into main Mar 31, 2025
17 checks passed
@d-j-hatton d-j-hatton deleted the better-visit-complete branch March 31, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants