Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
- Coverage 31.86% 31.85% -0.02%
==========================================
Files 91 91
Lines 10737 10747 +10
Branches 1425 1429 +4
==========================================
+ Hits 3421 3423 +2
- Misses 7203 7211 +8
Partials 113 113 🚀 New features to boost your workflow:
|
Contributor
|
I was thinking maybe we should have a config option to turn this behaviour off so we can make some systems more secure |
…ing the simpler 'user' token; allows this looser verification to be switched on or off per instrument
Contributor
Author
Added a key to the security config to optionally allow verification using the less secure 'user' token. |
d-j-hatton
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After implementing proper authentication between the backend, the client, and the web frontend, the TUI's previous authentication method was not considered, leading to it failing authentication when connecting to the backend server after the recent update.
This PR fixes that by adding an additional
elif ...block that takes the TUI's token into account and authorises that. In the longer term, having the TUI use the same authentication method as the instrument server would be ideal, but this is a lower priority.