Assign parameters per context rather than per environment#607
Merged
Assign parameters per context rather than per environment#607
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
==========================================
- Coverage 31.85% 31.82% -0.03%
==========================================
Files 91 90 -1
Lines 10747 10697 -50
Branches 1429 1417 -12
==========================================
- Hits 3423 3404 -19
+ Misses 7211 7178 -33
- Partials 113 115 +2 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Jun 12, 2025
| @@ -421,11 +421,16 @@ def _start_dc(self, json, from_form: bool = False): | |||
| json = json.get("form", {}) | |||
Contributor
There was a problem hiding this comment.
Any chance json could be replaced with something more indicative of its contents, since it seems to be passed around quite a bit?
Contributor
Author
There was a problem hiding this comment.
Done this. Might need to check that I haven't broken anything by missing references to it
tieneupin
reviewed
Jun 12, 2025
tieneupin
approved these changes
Jun 12, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Some comments about variable names, but other than that, no obvious issues. The test runs also seem to work as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses two problems which came up:
To resolve the multigrid problems I have moved the parameters from the environment to the context.
This also removes some of the client-side parameters which aren't needed such as boxsizes.