Skip to content

Pass machine config from Analyser and MultigridController to Context and related functions#761

Merged
tieneupin merged 7 commits intomainfrom
pass-machine-config-to-context
Mar 18, 2026
Merged

Pass machine config from Analyser and MultigridController to Context and related functions#761
tieneupin merged 7 commits intomainfrom
pass-machine-config-to-context

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Mar 16, 2026

As part of work done to implement file blacklisting (see #707 ), the machine config is already stored in the Analyser and MultigridController classes. As such, instead of making a get_machine_config_client call within the Context class or context-related functions, we can instead pass them the machine config or its values from the Analyser/MultigridController class that calls them.

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.85%. Comparing base (b78c905) to head (0593b80).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   48.85%   48.85%   -0.01%     
==========================================
  Files          93       93              
  Lines       10185    10182       -3     
  Branches     1326     1324       -2     
==========================================
- Hits         4976     4974       -2     
- Misses       4959     4960       +1     
+ Partials      250      248       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin marked this pull request as ready for review March 17, 2026 09:36
@tieneupin tieneupin requested review from d-j-hatton and stephen-riggs and removed request for stephen-riggs March 17, 2026 09:36
@tieneupin tieneupin self-assigned this Mar 17, 2026
@tieneupin tieneupin added the client Relates to the client component label Mar 17, 2026
@tieneupin tieneupin changed the title Pass Machine Config from Analyser to Context Pass Machine Config from Analyser and MultigridController to Context functions Mar 17, 2026
@tieneupin tieneupin changed the title Pass Machine Config from Analyser and MultigridController to Context functions Pass Machine Config from Analyser and MultigridController to Context and related functions Mar 17, 2026
@tieneupin tieneupin changed the title Pass Machine Config from Analyser and MultigridController to Context and related functions Pass machine config from Analyser and MultigridController to Context and related functions Mar 17, 2026
Copy link
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem worth doing and code changes look fine to me

@tieneupin tieneupin merged commit 9975f24 into main Mar 18, 2026
17 checks passed
@tieneupin tieneupin deleted the pass-machine-config-to-context branch March 18, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants