Clean code s1e1 by Dias1c · Pull Request #1 · Dias1c/clean-code-s1e1

Dias1c · 2024-12-16T13:07:17Z

Task: https://github.com/rolling-scopes-school/tasks/blob/master/stage1/modules/clean-code/clean-code-s1e1.md
Screenshot:

Deploy: Не деплоил
Done 16.12.2024 / deadline 17.12.2024
Score: 90 / 90

Можно заметить что интервал коммитов маленький, дело в том что я текста коммитов делал не верными, по этому пришлось применить git rebase -i HEAD~28 и git push -f что переписала коммиты. На самом деле над этим работал весь день.

…ndex.html

…ing to new line

…tic (main, section) in index.html

…o BEM convention

….css

… js script

…o bem

Dias1c added 28 commits December 16, 2024 18:13

fix(html-and-css.md-1.1): 4 spaces to 2 spaces in style.css

3102ba1

fix(html-and-css.md-1.2): change uppercase tag head to lowercase in i…

11cdad4

…ndex.html

fix(html-and-css.md-1.2): fix color values in style.css

d5ee5b7

fix(html-and-css.md-1.2): fix tag attributes to lowercase in index.html

a5d7032

fix(html-and-css.md-1.3): replace single quotes in index.html

2fa5507

fix(html-and-css.md-1.3): replace single quotes in style.css

87ee74c

fix(html-and-css.md-2.1): format index.html

012db4a

fix(html-and-css.md-2.2): add doctype in index.html

196f7d1

fix(html-and-css.md-2.3): replace spec characters in index.html

689a06e

fix(html-and-css.md-2.4): remove type attributes in index.html

95ad0fd

fix(html-and-css.md-3.1): format css selectors naming

39c8697

fix(html-and-css.md-3.2): update selectors naming

d9367f7

fix(html-and-css.md-3.2): refactor selectors naming

dfbab5a

fix(me): move reset styles to top & add new lines

02d5f1d

fix(html-and-css.md-3.5): style.css

9e654cd

fix(html-and-css.md-3.6): add spaces in style.css

2c0183b

fix(html-and-css.md-3.7): add closing ';' to property in style.css

a16084c

fix(html-and-css.md-3.8): update container-hero in style.css with mov…

3c6dee1

…ing to new line

fix(html-and-css.md-3.8): separate selectors style.css

9f9d7d0

fix(html-and-css-extended.md-1.1): replace non semantic tags to seman…

1a5f0ee

…tic (main, section) in index.html

refactor(me): separate tags in index.html

d9d3605

fix(html-and-css-extended.md-1.2): added alt to img in index.html

969c643

refactor(me): add space in tag attrs in index.html

2c327c3

refactor(me): add space after tag name in style.css

3b1377c

fix(html-and-css.md-1.3): quotes in css file

078095c

fix(html-and-css-extended.md-2.1): updated class names to BEM convention

f159144

fix(html-and-css-extended.md-2.1): update class names and selectors t…

ae614ae

…o BEM convention

fix(html-and-css.md-3.4): replace tags with classes

a6f1ca1

Dias1c force-pushed the clean-code-s1e1 branch from a18a9e4 to a6f1ca1 Compare December 16, 2024 13:21

fix(html-and-css.md-3.7): add semicolon after all properties in style…

1ba86fb

….css

Dias1c added 4 commits December 17, 2024 17:12

refactor(me): remove unused id

de393a4

fix(html-and-css.md-3.1): use signle style for selector names (id names)

cefe51d

fix(html-and-css-extended.md-1.2): updated alt attributes in html and…

7b73f70

… js script

fix(html-and-css-extended.md-2.1, html-and-css-3.3): update classes t…

761a952

…o bem

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean code s1e1#1

Clean code s1e1#1
Dias1c wants to merge 33 commits into
mainfrom
clean-code-s1e1

Dias1c commented Dec 16, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Dias1c commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Dias1c commented Dec 16, 2024 •

edited

Loading