fix: exclude audit metadata from snapshot hash#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tightens the deterministic snapshot hash boundary.
It removes audit/non-deterministic metadata from the version canonical lines used for snapshot hashing:
LabelActorIDCreatedAtUnixThese values remain available as metadata, but no longer affect deterministic state identity.
Why
DigiEmu Core v1.0 requires stable deterministic state hashes.
Before this change, identical deterministic content states with different timestamps or generated labels produced different snapshot hashes.
Tests
Added regression tests:
TestSnapshotHashIgnoresCreatedAtUnixTestSnapshotHashIgnoresGeneratedLabelVerification
go test ./...