fix(git-backup): configurable push target via git_backup.remote/branch#116
Merged
Conversation
…branch Closes #63. The after_save git backup pushed with a bare `git push`, relying on the branch's upstream tracking. Fine for the standard `origin main` setup, but brittle for users with multiple remotes or non-standard tracking — memory could land on the wrong remote. - New `git_backup.remote` / `git_backup.branch` config keys. Both empty (the default) preserves the historical bare-push behaviour. - All three push sites route through a single `_push()` helper. - Remote-URL change validation (#67) now keys off the configured remote instead of hardcoded `origin`, so it guards the remote actually pushed to. - First push logs the resolved target: `(remote 'X', branch 'Y')`. - README documents both keys. - New test proves the push routes to the configured remote and not origin. Co-Authored-By: Max <noreply>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63.
The
after_savegit backup pushed with a baregit push, relying on the branch's upstream tracking — fine for the standardorigin mainsetup, brittle for users with multiple remotes or non-standard tracking (memory could land on the wrong remote).Changes
git_backup.remote/git_backup.branchconfig keys. Both empty (the default) → bare push, preserving historical behavior._push()helper.origin— guards the remote actually pushed to.(remote 'X', branch 'Y').Tests
test_push_routes_to_configured_remote: proves the push lands on the configured remote and NOT origin; asserts state file + resolved-target log.