fix: emit === HANDOFF === hint only in external mode#118
Merged
Conversation
In legacy mode REMEMBER_HANDOFF resolves to {project}/.remember/remember.md
— the exact path the /remember skill defaults to when no === HANDOFF ===
block is present (SKILL.md:9). The hint carried no new info there, just noise.
Gate reuses the existing external-mode predicate (REMEMBER_ROOT != PROJECT_DIR)
already used for identity tiering. README.md:269 already documented this as
external-only behavior, so docs now match code. Adds a legacy-mode negative test.
Closes #61
Co-Authored-By: Max <noreply>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Implements #61.
session-start-hook.shemitted the=== HANDOFF ===write-target hint unconditionally. In legacy modeREMEMBER_HANDOFFresolves to{project}/.remember/remember.md— the exact path the/rememberskill already falls back to when no block is present (SKILL.md:9). So in legacy mode the hint was pure noise.Change
[ "$REMEMBER_ROOT" != "$PROJECT_DIR" ](same test already used for identity tiering at line 88 — one definition of "external", no drift).README.md:269already described this as external-only behavior, so docs now match code. No README change needed; the issue's "document the noise" alternative is moot.Tests
test_session_start_suppresses_handoff_block_in_legacy_mode(negative case). Proven red before the fix, green after.Closes #61