docs(rector-mcp): mark System error suppression as defense-in-depth (#273)#285
Merged
Merged
Conversation
…273) Root cause fixed upstream in dpt/mcp-rector-warm 0.4.0: the warm daemon now resets Rector's ResettableInterface services (incl. DynamicSourceLocatorProvider) per call, so the warm "ClassReflection must be resolved for class X" failure no longer fires. The adapter's `System error:` skip stays only to absorb any future non-deterministic engine glitch — no longer load-bearing. Comment + CHANGELOG only; no behavior change. Requires mcp-rector-warm >= 0.4.0. Co-Authored-By: Max <noreply>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause behind the warm
ClassReflection must be resolved for class Xfailures (#273) is fixed upstream indpt/mcp-rector-warm0.4.0: the warm daemon reused one Rector container and never resetDynamicSourceLocatorProvider, which caches its source locator for every non-PHPUnit run — so the second file in a warm session was analysed with a locator that only knew the first file. The daemon now resets reflection state per call (mirroringAbstractRectorTestCase).This PR updates
validators/rector-mcp/rector-mcp.pyso theSystem error:skip is documented as defense-in-depth (absorb any future non-deterministic engine glitch), not load-bearing. Comment + CHANGELOG only — no behavior change.Requires
dpt/mcp-rector-warm>= 0.4.0 (composer global update dpt/mcp-rector-warm). Merge the mcp-rector-warm PR + tag 0.4.0 first.Test plan