fix(install-hooks): merge instead of clobbering other plugins' hooks (0.14.2)#29
Merged
Conversation
…(0.14.2) install-hooks replaced the entire `hooks` block in settings.json, wiping any co-located third-party hooks (token-pilot, context-mode, …). It now merges: for each event it touches, strips only prior task-journal entries (idempotent) and appends its own, leaving foreign hooks and untouched events intact. Makes re-running install-hooks safe on a multi-plugin setup. Test: install over pre-existing third-party hooks → foreign hooks survive, task-journal added, re-install does not duplicate. fmt/clippy/test green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
install-hooksreplaced the entirehooksblock in settings.json — wiping any co-located third-party hooks (token-pilot, context-mode, …). Re-running it on a multi-plugin setup nuked everything else.Fix
It now merges: for each event it touches, it strips only prior task-journal entries (so re-install is idempotent) and appends its own, leaving foreign hooks and untouched events intact.
Test
install_hooks_merges_and_preserves_third_party_hooks: install over pre-existingother-pluginhooks on UserPromptSubmit + SessionStart → the foreign hooks survive, task-journal's nudge + resume get added, and a second install does not duplicate the nudge.cargo fmt --all --checkclean;cargo clippy --workspace --all-targetsclean;cargo test --workspacegreen.🤖 Generated with Claude Code