[pull] master from panda3d:master#9
Merged
Conversation
The picture of whether inline variables would be a step forwards here is actually a bit murky. The current solution is battle-tested, inclined not to fix what ain't broken.
Negligible user base, Python already dropped it, modern XCode can't target it anymore, and it is a blocker for C++17 Fixes #1718
Adds support for string_view, fixes parser issues, removes `using namespace std;` from generated code, and many other things (see interrogate changelog)
This is more efficient, avoids an extra copy when passing in strings from Python code
This is safe now that we use C++17 due to the changed rules on copy elision.
Though in practice compilers handled these cases as expected, C++17 introduced std::launder to legalize this pattern
The thirdparty package for OpenEXR is outdated, this problem will go away when the new thirdparty building mechanism on shaderpipeline branch lands
Methods taking std::string should generally either take std::string (if they're going to make a copy anyway) or std::string_view if they just need to access it temporarily, not const std::string & Map lookups have been made more efficient by making them use heterogenous lookup
Careful with this, since std::clamp has UB when max < min, so not all cases are converted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )