Upgrade RUBY on the WORKER#238
Merged
Merged
Conversation
Code quality scoreLovely, the code quality is unchanged for this PR 😊
|
chigginsboost
approved these changes
Jun 12, 2025
paul-mesnilgrente
approved these changes
Jun 16, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM ruby:3.2.2-alpine3.18 AS builder | |||
| FROM ruby:3.4.4-alpine AS builder | |||
Contributor
There was a problem hiding this comment.
Here it would be best to pin the alpine version, it's part of the best practices with Docker :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Dan, I want Ruby up to date on the WORKER, so that we are safe and secure from CVE's
Acceptance Criteria
-Rails is running on the latest Ruby (3.4.5 at the time of writing)(Currently 3.2.2)
-The app using the latest Alpine version available for that ruby version
Risks
-subtle dependencies changing how parsers code behaves?
Notes
-Upgrading Ruby will upgrade the Alpine version we're on. This will help to avoid CVEs
-This might be the previous upgrade 157784