Worker Rails 7.2#240
Merged
Merged
Conversation
Code quality scoreLovely, the code quality is unchanged for this PR 😊
|
| # gem 'supplejack_common', path: '~/Dev/supplejack/gems/supplejack_common' | ||
| # gem 'supplejack_common', github: 'DigitalNZ/supplejack_common', branch: 'pm/upgrade' | ||
| gem 'supplejack_common', github: 'DigitalNZ/supplejack_common', tag: 'v3.0.2' | ||
| gem 'supplejack_common', github: 'DigitalNZ/supplejack_common', branch: 'tw/rails-7-2' |
There was a problem hiding this comment.
Will this need changed before you merge? Do the other 2 commented out lines need removed?
Contributor
Author
There was a problem hiding this comment.
Yep I'll need to update this once the supplejack common PR is merged. Good point about commented lines, we can probably remove these.
danielaboost
approved these changes
Oct 10, 2025
chigginsboost
approved these changes
Oct 10, 2025
| system! "bin/rails restart" | ||
|
|
||
| # puts "\n== Configuring puma-dev ==" | ||
| # system "ln -nfs #{APP_ROOT} ~/.puma-dev/#{APP_NAME}" |
There was a problem hiding this comment.
question: do you need to include this commented out or can you remove?
Contributor
Author
There was a problem hiding this comment.
good question, it was added by 'rails app:update' could probably remove
| end | ||
|
|
||
| it 'does not flush records if a harvest failure occured' do | ||
| it 'does not flush records if a harvest failure occurred' do |
| config.force_ssl = true | ||
|
|
||
| # Skip http-to-https redirect for the default health check endpoint. | ||
| # config.ssl_options = { redirect: { exclude: ->(request) { request.path == "/up" } } } |
Contributor
Author
There was a problem hiding this comment.
good question, it was added by 'rails app:update' could probably remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worker Rails 7.2
As a Software Developer, I want to upgrade our Rails application from 7.1.5.1 to 7.2 so that we maintain support on the current Rails version
Acceptance Criteria: