Fix issue #15 of invalid normals primvars by removing elementSize#18
Merged
matthewlow-dwa merged 2 commits intoJul 17, 2026
Conversation
matthewlow-dwa
changed the title
Contributor
|
Thanks @HardCoreCodin ! A few checks came back that will block the merge -- could you rebase your changes onto the latest |
HardCoreCodin
force-pushed
the
fix_normals_primvar
branch
from
June 30, 2026 21:30
2932a4a to
3b902dd
Compare
…ll of them Signed-off-by: Arnon Marcus <hard.core.codin@gmail.com>
…ll of them to 1 Signed-off-by: Arnon Marcus <hard.core.codin@gmail.com>
HardCoreCodin
force-pushed
the
fix_normals_primvar
branch
from
June 30, 2026 21:35
3b902dd to
a4f9fb6
Compare
Contributor
Author
|
Apologies for the delay @matthewlow-dwa . I've pushed the rebased commits with the signoffs now. |
matthewlow-dwa
approved these changes
Jul 15, 2026
matthewlow-dwa
left a comment
matthewlow-dwa
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @HardCoreCodin !
@theblackunknown , did you want to take a look before this is released?
Contributor
|
Confirmed with @theblackunknown on Slack that this is good to release. Thanks again @HardCoreCodin ! We'll create an official release once #22 is merged. |
matthewlow-dwa
merged commit Jul 17, 2026
1a1c6cd
into
DigitalProductionExampleLibrary:main
2 checks passed
Contributor
|
Yes sorry for being late on this, I confirm we have discussed it and this fix looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids crashing Blender (4.5 and 5.0) and Cinema4D (2026.1) when importing this scene.