Skip to content

feat(layer2): add integration Boba Network#5310

Closed
developerfred wants to merge 61 commits into
DimensionDev:developfrom
developerfred:feat/integration-boba-network
Closed

feat(layer2): add integration Boba Network#5310
developerfred wants to merge 61 commits into
DimensionDev:developfrom
developerfred:feat/integration-boba-network

Conversation

@developerfred

@developerfred developerfred commented Dec 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

@developerfred
developerfred changed the base branch from develop to master December 27, 2021 00:45
@UncleBill

UncleBill commented Dec 27, 2021

Copy link
Copy Markdown
Contributor

Hey, @developerfred , you should set the target of a pull request to develop branch.

@developerfred
developerfred changed the base branch from master to develop December 27, 2021 03:10
@developerfred developerfred mentioned this pull request Dec 27, 2021
Merged
4 tasks
@developerfred
developerfred force-pushed the feat/integration-boba-network branch from dc1c59c to f1fc93e Compare December 29, 2021 21:27
@developerfred
developerfred force-pushed the feat/integration-boba-network branch from f1fc93e to d6b62cb Compare December 29, 2021 21:38
@developerfred
developerfred force-pushed the feat/integration-boba-network branch from 0d11098 to 0367a14 Compare December 30, 2021 07:22
septs
septs reviewed Jan 5, 2022
View reviewed changes
Comment thread packages/mask/src/plugins/ITO/SNSAdaptor/ClaimAllDialog.tsx Outdated
septs
septs reviewed Jan 5, 2022
View reviewed changes
Comment thread packages/mask/src/plugins/ITO/SNSAdaptor/ClaimAllDialog.tsx Outdated
septs
septs reviewed Jan 5, 2022
View reviewed changes
Comment thread packages/mask/src/plugins/Trader/trader/useGetTradeContext.ts Outdated
septs
septs reviewed Jan 5, 2022
View reviewed changes
Comment thread packages/mask/src/plugins/Trader/trader/useTradeContext.ts Outdated
@wenluomask

wenluomask commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

#1 and #2 still existed.
#3 and #4 fixed.

  1. The boba icon on wallet pages will disappear sometimes;
    https://user-images.githubusercontent.com/85149605/153341222-3b73f872-be6f-48de-b6ec-d94c1b334cfb.mov

  2. Transfer BOBA in Dashboard didn't get the gas limit;

Screen.Recording.2022-02-10.at.1.05.48.PM.mov

Screen Shot 2022-02-10 at 1 06 30 PM

@developerfred
developerfred force-pushed the feat/integration-boba-network branch from 1ac5511 to ec5abef Compare February 10, 2022 13:12
@developerfred

developerfred commented Feb 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@wenluomask can you test the transfer again? bug number 6

@developerfred

developerfred commented Feb 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

eth_sendTransaction and eth_getAccounts Unsupported JSON-RPC methods on BobaNetwork ref: https://docs.boba.network/developer-docs/json-rpc-api#unsupported-json-rpc-methods

fixed here 7e2e385

@developerfred

developerfred commented Feb 10, 2022

Copy link
Copy Markdown
Contributor Author

@UncleBill @Jack-Works @septs Hi guys, I made this change to the eth_sendTransaction method, can you review it for me?

@developerfred
developerfred force-pushed the feat/integration-boba-network branch from 7e2e385 to 6eecb9e Compare February 10, 2022 15:12
@developerfred developerfred mentioned this pull request Feb 11, 2022
Closed
@wenluomask

wenluomask commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

Only #1 and #6 were not fixed yet.

In addition, I found out duplicate Eth token in token list.
Screen Shot 2022-02-11 at 5 55 33 PM

Jack-Works
Jack-Works previously approved these changes Feb 14, 2022
View reviewed changes
Jack-Works
Jack-Works previously approved these changes Mar 12, 2022
View reviewed changes
@developerfred
developerfred force-pushed the feat/integration-boba-network branch from 4bd5f48 to 39b038d Compare March 12, 2022 11:11
@developerfred
developerfred force-pushed the feat/integration-boba-network branch from 3026a6b to 29ead68 Compare March 21, 2022 06:49
@developerfred
developerfred force-pushed the feat/integration-boba-network branch from 29ead68 to 23ae595 Compare March 21, 2022 07:20
@guanbinrui

guanbinrui commented Mar 23, 2022

Copy link
Copy Markdown
Member

I'm closing this PR. Cause it doesn't belong to any bounty issue.

@guanbinrui guanbinrui closed this Mar 23, 2022
@developerfred

developerfred commented Mar 23, 2022

Copy link
Copy Markdown
Contributor Author

@guanbinrui ok if one day I enter the reward program do I need to reopen?

@guanbinrui

guanbinrui commented Mar 23, 2022

Copy link
Copy Markdown
Member

@guanbinrui ok if one day I enter the reward program do I need to reopen?

Yes, please link it if any bounty issue opened.

@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jack-Works Jack-Works Jack-Works left review comments
@septs septs Awaiting requested review from septs
@UncleBill UncleBill Awaiting requested review from UncleBill

Assignees

No one assigned

Labels

Plugin: EVM Type: Bounty

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@developerfred @UncleBill @wenluomask @guanbinrui @septs @Jack-Works