new: add SAF support for SD card recording on Android 10+ #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaab
force-pushed
the
saf-sdcard-storage
branch
from
943ac12 to
8be71cc
Compare
Implement Storage Access Framework (SAF) to allow saving recordings to SD card public directories on Android 10, where traditional file APIs are blocked by Scoped Storage. Key changes: - Add ``RecordingTarget`` abstraction for File vs SAF URI targets - Add storage location selector in Settings (Internal/SD card/Custom) - Launch SAF folder picker when SD card is selected - Use ``DocumentsContract.createDocument()`` + ``FileDescriptor`` for recording - Add ``WavSafNotSupportedException`` - WAV format unsupported with SAF (requires ``RandomAccessFile`` for header updates) - Fix resource leak in ``RecordingTarget.openForWriting()`` - Fix null checks in ``AppRecorderImpl`` timer methods - Add translations for 8 new strings in all 9 locales Recordings saved via SAF survive app uninstall, achieving the goal of persistent SD card storage on Android 10.
vaab
force-pushed
the
saf-sdcard-storage
branch
from
8be71cc to
2d50a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Storage Access Framework (SAF) to allow saving recordings to SD card public directories on Android 10, where traditional file APIs are blocked by Scoped Storage.
Key changes:
RecordingTargetabstraction for File vs SAF URI targetsDocumentsContract.createDocument()+FileDescriptorfor recordingWavSafNotSupportedException- WAV format unsupported with SAF (requiresRandomAccessFilefor header updates)RecordingTarget.openForWriting()AppRecorderImpltimer methodsRecordings saved via SAF survive app uninstall, achieving the goal of persistent SD card storage on Android 10.
If this is of any interest, please feel free to re-use. I just wanted persistent SD card storage on Android 10.