Conversation
There was a problem hiding this comment.
4 issues found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="assignments/submissions/40240378/01/python/matrizes_tipos.py">
<violation number="1" location="assignments/submissions/40240378/01/python/matrizes_tipos.py:74">
P2: Restrict the identity check to square matrices; otherwise rectangular matrices like `np.eye(3, 4)` are classified as `identity`.</violation>
</file>
<file name="assignments/submissions/40240378/01/python/Reflexao.md">
<violation number="1" location="assignments/submissions/40240378/01/python/Reflexao.md:1">
P2: Rename this file to `reflexao.md` to match the required filename; the current casing can break case-sensitive validation.</violation>
</file>
<file name="assignments/submissions/40240378/01/python/README.md">
<violation number="1" location="assignments/submissions/40240378/01/python/README.md:9">
P2: The documented run command points to a non-existent nested `python/` path from this README's directory.</violation>
<violation number="2" location="assignments/submissions/40240378/01/python/README.md:17">
P3: This table entry names a file that does not exist with this casing; the submission contains `Reflexao.md` instead.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
@Delcio1760 is this ready for review? |
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="assignments/submissions/40240378/01/python/matrizes_tipos.py">
<violation number="1" location="assignments/submissions/40240378/01/python/matrizes_tipos.py:74">
P0: Indent the identity check under the new square-matrix guard; as written, this introduces an `IndentationError` and the script will not start.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| if np.allclose(matriz, 0): | ||
| classificacoes.append("zero") | ||
|
|
||
| if numero_linhas == numero_colunas: |
There was a problem hiding this comment.
P0: Indent the identity check under the new square-matrix guard; as written, this introduces an IndentationError and the script will not start.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At assignments/submissions/40240378/01/python/matrizes_tipos.py, line 74:
<comment>Indent the identity check under the new square-matrix guard; as written, this introduces an `IndentationError` and the script will not start.</comment>
<file context>
@@ -71,7 +71,8 @@ def classificar_matriz(matriz):
classificacoes.append("zero")
- if np.allclose(matriz, np.eye(numero_linhas, numero_colunas)):
+ if numero_linhas == numero_colunas:
+ if np.allclose(matriz, np.eye(numero_linhas)):
classificacoes.append("identity")
</file context>
|
Yes it is
Diogo Ribeiro ***@***.***> escreveu (quarta, 18/03/2026 à(s)
18:03):
… *DiogoRibeiro7* left a comment
(DiogoRibeiro7/linear-algebra-with-python#18)
<#18 (comment)>
@Delcio1760 <https://github.com/Delcio1760> is this ready for review?
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BL6TV24WBMLQO5JCFLZGTGL4RLQIXAVCNFSM6AAAAACWT7EGUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAOBUGU3DAOJZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
still to early for that, you should have waited for my go ahead |
| if np.allclose(matriz, 0): | ||
| classificacoes.append("zero") | ||
|
|
||
| if numero_linhas == numero_colunas: |
There was a problem hiding this comment.
@Delcio1760 you have a coding error in this line, probably a missing line
Submission Metadata
A01-A06):pythonorjavascript):assignments/submissions/<student>/<nn>/):Student Submission Checklist
develop<student_number>-A<nn>(example:4025001-A01)Submission <student_number> --- A<nn>A01andA06assignments/submissions/<student>/<nn>/README.mdexists in the submission folderreflexao.mdexists in the submission folderpython/orjavascript/, not both)Notes (optional)
Summary by cubic
Adds Assignment A01 for student 40240378: a Python solution using
numpyto build and classify special matrices and to demonstrate dimension errors. Adds README files and reflection, organized under the corrected submission folder layout.New Features
python/matrizes_tipos.py(T1–T4): creates zeros/identity/diagonal/triangular/symmetric matrices, reports shapes and element [2,3], classifies matrices, and shows errors for incompatible sums/products.np.allclose,np.eye,np.diag,np.triu, andnp.tril.01/README.mdwith run steps and file map;reflexao.mdcovers identity matrix multi-class membership and a brief Python vs JS comparison.Refactors
.gitkeepand a student-levelassignments/submissions/40240378/README.md.Written for commit 5b1a3db. Summary will update on new commits.