Skip to content

Submission 40240378 — A01#18

Open
Delcio1760 wants to merge 2 commits intodevelopfrom
40240378-A01
Open

Submission 40240378 — A01#18
Delcio1760 wants to merge 2 commits intodevelopfrom
40240378-A01

Conversation

@Delcio1760
Copy link
Copy Markdown
Collaborator

@Delcio1760 Delcio1760 commented Mar 16, 2026

Submission Metadata

  • Student number:
  • Assignment code (A01-A06):
  • Language track (python or javascript):
  • Submission folder path (assignments/submissions/<student>/<nn>/):

Student Submission Checklist

  • This PR targets develop
  • Source branch follows <student_number>-A<nn> (example: 4025001-A01)
  • PR title follows Submission <student_number> --- A<nn>
  • Assignment code is between A01 and A06
  • All changed files are inside assignments/submissions/<student>/<nn>/
  • README.md exists in the submission folder
  • reflexao.md exists in the submission folder
  • Exactly one language track is present (python/ or javascript/, not both)

Notes (optional)


Summary by cubic

Adds Assignment A01 for student 40240378: a Python solution using numpy to build and classify special matrices and to demonstrate dimension errors. Adds README files and reflection, organized under the corrected submission folder layout.

  • New Features

    • python/matrizes_tipos.py (T1–T4): creates zeros/identity/diagonal/triangular/symmetric matrices, reports shapes and element [2,3], classifies matrices, and shows errors for incompatible sums/products.
    • Classification uses np.allclose, np.eye, np.diag, np.triu, and np.tril.
    • 01/README.md with run steps and file map; reflexao.md covers identity matrix multi-class membership and a brief Python vs JS comparison.
  • Refactors

    • Corrected folder structure to match the submission schema; added .gitkeep and a student-level assignments/submissions/40240378/README.md.

Written for commit 5b1a3db. Summary will update on new commits.

@github-actions github-actions bot added invalid Submission failed validation and removed invalid Submission failed validation labels Mar 16, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 issues found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="assignments/submissions/40240378/01/python/matrizes_tipos.py">

<violation number="1" location="assignments/submissions/40240378/01/python/matrizes_tipos.py:74">
P2: Restrict the identity check to square matrices; otherwise rectangular matrices like `np.eye(3, 4)` are classified as `identity`.</violation>
</file>

<file name="assignments/submissions/40240378/01/python/Reflexao.md">

<violation number="1" location="assignments/submissions/40240378/01/python/Reflexao.md:1">
P2: Rename this file to `reflexao.md` to match the required filename; the current casing can break case-sensitive validation.</violation>
</file>

<file name="assignments/submissions/40240378/01/python/README.md">

<violation number="1" location="assignments/submissions/40240378/01/python/README.md:9">
P2: The documented run command points to a non-existent nested `python/` path from this README's directory.</violation>

<violation number="2" location="assignments/submissions/40240378/01/python/README.md:17">
P3: This table entry names a file that does not exist with this casing; the submission contains `Reflexao.md` instead.</violation>
</file>

Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@DiogoRibeiro7
Copy link
Copy Markdown
Owner

@Delcio1760 is this ready for review?

@github-actions github-actions bot added invalid Submission failed validation and removed invalid Submission failed validation labels Mar 19, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="assignments/submissions/40240378/01/python/matrizes_tipos.py">

<violation number="1" location="assignments/submissions/40240378/01/python/matrizes_tipos.py:74">
P0: Indent the identity check under the new square-matrix guard; as written, this introduces an `IndentationError` and the script will not start.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

if np.allclose(matriz, 0):
classificacoes.append("zero")

if numero_linhas == numero_colunas:
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0: Indent the identity check under the new square-matrix guard; as written, this introduces an IndentationError and the script will not start.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At assignments/submissions/40240378/01/python/matrizes_tipos.py, line 74:

<comment>Indent the identity check under the new square-matrix guard; as written, this introduces an `IndentationError` and the script will not start.</comment>

<file context>
@@ -71,7 +71,8 @@ def classificar_matriz(matriz):
         classificacoes.append("zero")
 
-    if np.allclose(matriz, np.eye(numero_linhas, numero_colunas)):
+    if numero_linhas == numero_colunas:
+    if np.allclose(matriz, np.eye(numero_linhas)):
         classificacoes.append("identity")
</file context>
Fix with Cubic

@Delcio1760
Copy link
Copy Markdown
Collaborator Author

Delcio1760 commented Mar 19, 2026 via email

@DiogoRibeiro7
Copy link
Copy Markdown
Owner

Yes it is Diogo Ribeiro @.> escreveu (quarta, 18/03/2026 à(s) 18:03):

DiogoRibeiro7 left a comment (DiogoRibeiro7/linear-algebra-with-python#18) <#18 (comment)> @Delcio1760 https://github.com/Delcio1760 is this ready for review? — Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BL6TV24WBMLQO5JCFLZGTGL4RLQIXAVCNFSM6AAAAACWT7EGUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAOBUGU3DAOJZGI . You are receiving this because you were mentioned.Message ID: @.
>

still to early for that, you should have waited for my go ahead

@github-actions github-actions bot added invalid Submission failed validation and removed invalid Submission failed validation labels Mar 24, 2026
if np.allclose(matriz, 0):
classificacoes.append("zero")

if numero_linhas == numero_colunas:
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Delcio1760 you have a coding error in this line, probably a missing line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid Submission failed validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants