Open
Conversation
Non-functional skeleton matching the mockup for the extract-nodes tool. Uses (extract) route group with own root layout, two-panel Sidebar + MainContent. All data hardcoded — no wiring or functionality.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
The border-border class from shadcn globals.css is not defined in the extract layout's Tailwind context. The (home) layout doesn't import it either — not needed for this skeleton.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Remove <html> and <body> from (extract) layout — root layout already provides these. Matches (home) layout pattern. - Align TABS counts and footer text with actual SAMPLE_NODES data (6 items: 3 CLM + 3 EVD).
- Add shadcn Button, Badge, Checkbox to @repo/ui - Rewrite Sidebar: use Checkbox, Button; node types now match discourse graph ontology (CLM, QUE, HYP, EVD, RES, SRC, THE) with candidateTag field per ENG-1603 spec shape - Rewrite MainContent: use Badge for type labels, Checkbox for selection, Button for actions - Remove prototype node types (EXP, MTD, PAT, CON, ISS, ART) that don't exist in the ontology
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Align shadcn-generated code with repo conventions: interface → type, function → arrow, prettier formatting.
Sidebar: NODE_TYPES with all ENG-1603 fields (label, description, candidateTag, color) colocated in component. MainContent: SAMPLE_NODES with all ENG-1601 fields (nodeType, content, supportSnippet, sourceSection) colocated in component. supportSnippet shown inline. Colors looked up from nodeType. Removed sampleData.ts — shared types will be a Zod schema later.
- All 7 node types checked in sidebar - Sample extracted nodes for every type (claim, evidence, question, hypothesis, result, source, theory) - First 2 cards show expanded supportSnippet, rest collapsed - Buttons use explicit dark gradient instead of shadcn theme
Use Button from @repo/ui with className overrides for slate-900 dark theme instead of raw HTML buttons.
Sidebar: shadcn Checkbox replaces custom colored checkboxes. MainContent: Card+CardContent for result cards, Badge for filter tabs, Checkbox for selection, Button variant=ghost for show/hide details. Colored inline style only on the nodeType pill in each result card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.