updated error message to i18t#2
Open
CapellaBlue wants to merge 7 commits into
Open
Conversation
bradseefeld
reviewed
Sep 9, 2017
| @@ -0,0 +1,41 @@ | |||
| ### Questions to ask when evaluating an influencer campaign | |||
There was a problem hiding this comment.
Dont think you meant to push this ;)
bradseefeld
reviewed
Sep 9, 2017
| errors.add(:password, "is a very common password. Please choose something harder to guess.") | ||
| errors.add(:password, def not_common_password | ||
| if Devise::Models::UncommonPassword.common_passwords.include? password.downcase | ||
| errors.add(:password, I18n.t('errors.messages.common_password')) |
There was a problem hiding this comment.
This string doesnt exist yet in our app
There was a problem hiding this comment.
What I mean is, we need to add it. That is why you're not seeing the error message when testing.
Author
There was a problem hiding this comment.
okay, thank you!
Since it's been added to to the devise yaml file, (errors.messages.common_passord), I'm unsure where else to place this string.
Author
|
Removed:)
…On Sep 8, 2017 6:33 PM, "Brad Seefeld" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/review_guide.md
<#2 (comment)>
:
> @@ -0,0 +1,41 @@
+### Questions to ask when evaluating an influencer campaign
Dont think you meant to push this ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOZZEkaMdRNnUkpzDeCbBwGMqsFWKwQXks5sgerWgaJpZM4PRyXP>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.