Fix macOS build: guard Win32-only sa_push_canvas_rect_to_runtime calls (#131)#134
Merged
Merged
Conversation
#131) The standalone 2D-surround work (#131) added two calls to sa_push_canvas_rect_to_runtime() at displayxr_standalone.cpp:1657 (submit path) and :2107 (surround_clear) outside any platform guard, but the function is defined inside the file's `#if defined(_WIN32)` block. The Windows half of CI stayed green so it slipped through the cheap PR builds; the macOS Universal job failed with "use of undeclared identifier 'sa_push_canvas_rect_to_runtime'" and blocked the v1.11.0 release. Wrap both call sites in `#if defined(_WIN32)`. Standalone surround is Windows-D3D12-only (surround_active never sets on other backends), so the canvas-rect push is a no-op elsewhere — behavior is unchanged on every platform; this only restores the macOS compile. Windows DLL rebuilt (identical codegen on the Win32 path). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone 2D-surround work (#131) added two calls to
sa_push_canvas_rect_to_runtime() at displayxr_standalone.cpp:1657 (submit
path) and :2107 (surround_clear) outside any platform guard, but the function
is defined inside the file's
#if defined(_WIN32)block. The Windows half ofCI stayed green so it slipped through the cheap PR builds; the macOS Universal
job failed with "use of undeclared identifier 'sa_push_canvas_rect_to_runtime'"
and blocked the v1.11.0 release.
Wrap both call sites in
#if defined(_WIN32). Standalone surround isWindows-D3D12-only (surround_active never sets on other backends), so the
canvas-rect push is a no-op elsewhere — behavior is unchanged on every
platform; this only restores the macOS compile. Windows DLL rebuilt (identical
codegen on the Win32 path).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com