Rusty#2
Open
mybodis4you wants to merge 91 commits into
Open
Conversation
Use mechanism for obtaining the upper limit value.
Remove redundant import.
Improve temporaries naming.
In making the variables final we prevent the possibility of them ever being changed (outside of abnormal situations such as reflection), hence making it easier for an enterprise developer to follow along with the code, as they know that the final variables' values will never be changed and therefore do not have to look for changes to the variables in order to find out why odd behaviour is occurring. Obviously, this is largely hypothetical and just to put developers' minds at rest as there is no way that odd behaviour could ever occur in such excellently written enterprise code.
Use adapter for handling exceptions from output.
Replaces literal zero with named final integral
fix whitespace
You seem to have missed the 0 from the initial dbRoundedQuotient.
Refactored one of the remaining constants.
Fix code style violation reported in PR#184
Conflicts: src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/Main.java
…lity, access via this. to fields.
Update LoopComponentFactory.java SHI~!!! SHI~!!! Oh, sorry, we're in the middle of a Very Important Meeting and I spilled coffee onto the projector... After running this change through all the evaluation and validation procedures it is being merged. Thanks a lot for bringing this to our attention.
Conflicts: src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/factories/LoopComponentFactory.java
Fix whitespace
tests platform-independent.
tests platform-independent.
…ngSeriousDocumentation * commit 'eb136adb7490ef97e5ba7f97d2b9b75f489097e3': Documentation for interfaces, etc Documentation for the printers package Documentation for Parameters package Documentatino for math.arithmetic package Documentation for Loop package # Conflicts: # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/loop/LoopInitializer.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/loop/LoopStep.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/strategies/adapters/FizzBuzzOutputStrategyToFizzBuzzExceptionSafeOutputStrategyAdapter.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/strategies/adapters/LoopContextStateRetrievalToSingleStepOutputGenerationAdapter.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/strategies/comparators/doublecomparator/FirstIsLargerThanSecondDoubleComparator.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/strategies/converters/primitivetypesconverters/DoubleToIntConverter.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/stringreturners/NewLineStringReturner.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/FizzBuzz.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/factories/FizzBuzzOutputStrategyFactory.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/factories/IntegerPrinterFactory.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/factories/IntegerStringReturnerFactory.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/factories/IsEvenlyDivisibleStrategyFactory.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/factories/OutputGenerationContextVisitorFactory.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/factories/StringPrinterFactory.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/printers/DataPrinter.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/strategies/FizzBuzzOutputStrategy.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/strategies/IsEvenlyDivisibleStrategy.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/strategies/OutputGenerationStrategy.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/stringreturners/IntegerStringReturner.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/stringreturners/StringStringReturner.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/visitors/OutputGenerationContext.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/interfaces/visitors/OutputGenerationContextVisitor.java
Include Gradle config
FindBugs fix; Windows build fix.
I noticed that the String construtor was being called without specifying the start offset and count. This is unacceptable. How do I know if it's copying all the characters unless I can actually see it in the code. In this change, you'll get the distinct air of superiority as you have now begun dealing with low-level constructs such as arrays. As they say, rub on some arrays, and watch the women flock.
FizzStringReturner may not have copied all characters
… into seriousDocumentation * 'master' of github.com:ecurtin/FizzBuzzEnterpriseEdition: FizzStringReturner may not have copied all characters Increase code coverage (now 91%). Fix whitespace per PR review comments. Workaround for failing tests on Windows. TODO: Raise ticket to make tests platform-independent. Workaround for failing tests on Windows. TODO: Raise ticket to make tests platform-independent. Fix FindBugs warning in ApplicationContextHolder. Fixed a weird dependency Include Gradle config closes #230 # Conflicts: # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/ApplicationContextHolder.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/math/arithmetics/NumberIsMultipleOfAnotherNumberVerifier.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/printers/BuzzPrinter.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/printers/FizzPrinter.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/printers/IntegerPrinter.java # src/main/java/com/seriouscompany/business/java/fizzbuzz/packagenamingpackage/impl/printers/NewLinePrinter.java
…ts to most interface declarations.
Serious Documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading obs-studio-master.zip…