fix: allow istioGateway common values in schema#275
Open
iharrington wants to merge 1 commit into
Open
Conversation
The values.schema.json for istioGateway.values only allowed 'gateways' property with additionalProperties set to false. This prevented passing common configuration like waitJob, networkPolicies, mtls, and upstream through the BigBang chart to the underlying istio-gateway package. Added waitJob, networkPolicies, mtls, and upstream properties to the schema to allow users to configure these common settings (e.g., disabling wait job, overriding images, configuring network policies).
Author
|
I tried to do the fork in https://repo1.dso.mil/big-bang/bigbang, I have an account but it gave me a 403... so I went this route. Also my own main concern is the "disabling wait job" so if any of the other parts cause issues can we focus there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values.schema.json for istioGateway.values only allowed 'gateways' property with additionalProperties set to false. This prevented passing common configuration like waitJob, networkPolicies, mtls, and upstream through the BigBang chart to the underlying istio-gateway package.
Added waitJob, networkPolicies, mtls, and upstream properties to the schema to allow users to configure these common settings (e.g., disabling wait job, overriding images, configuring network policies).