fix(decks): stop deleted decks resurrecting across devices (tombstones)#15
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…k delete Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…kAs and addEmptyDeck mutateActiveWorkspace replaces (not merges), so these two callbacks were dropping deletedDecks/pairedAgents/allowSiblingExposure. With tombstones now load-bearing for cross-device delete propagation, a Save-As or Add-Deck right after a remote delete-merge could wipe tombstones and resurrect the deck. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying jank with
|
| Latest commit: |
cded8ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a7afe867.jank-4ii.pages.dev |
| Branch Preview URL: | https://feat-deck-delete-propagation.jank-4ii.pages.dev |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleted decks were reappearing across devices/tabs because the NIP-78 deck-sync merge did a pure union with no record of deletions. This adds a
deletedDeckstombstone map (deckId → deletedAt ms) to the per-account workspace:deleteDeckrecords a tombstone; the merge honors it with last-writer-wins — a deck only returns if it was saved after the delete, or is kept-and-flagged-as-conflict if it has unsaved local edits. Includes a 90-day GC and a never-leave-the-user-deckless safety net.WIRE_VERSIONstays 1 (fully backward-compatible — old clients ignore the field, new clients reading old blobs see no tombstones).storage.restoreDeck).deleteDeck,saveActiveDeckAs, andaddEmptyDeckrebuilt the workspace without spreading existing fields, silently droppingpairedAgents/allowSiblingExposure(and, post-this-feature, tombstones). AllmutateActiveWorkspacecallbacks audited.5 commits, +27 tests. No new dependencies. No wire-version bump, no data migration.
Test plan
npm run buildgreen; full suite 889 passed / 1 skipped / 0 failed🤖 Generated with Claude Code