Client tag (NIP-89) reads JANK#19
Merged
Merged
Conversation
The ['client', ...] label other clients show as 'posted via ...' used BRAND.nostrClientTag = 'jank'. It's a bare label with no d-tag / handler address and nothing matches the string in logic, so it's visible brand copy, not a wire identifier. Flip it to JANK to match the rest of the brand (caught by Daniel post-review). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18 (caught post-merge). The NIP-89 client tag — the "posted via …" label other Nostr clients show — was still
jank, because I'd bucketednostrClientTagwith the wire identifiers when I shipped #18. It isn't one: it's built as a bare['client', 'jank']label (src/lib/draft-event.ts) with no NIP-89 handlerd-tag and nothing matching the string in logic, so it's visible brand copy. Flipped toJANKso posts read "via JANK", consistent with the rest of the brand.One-line value change in
branding.ts(+ a comment so it doesn't get re-lowercased as a "wire id" later).npm run buildgreen.The genuine wire/machine IDs still stay lowercase on purpose: npm package
name, the deck-syncd-tag, and the MCPserverInfo.name.No version bump / release-notes entry — trivial consistency follow-up that ships under the 26.15.2 JANK theme. Say the word if you'd rather I bump to 26.15.3.
🤖 Generated with Claude Code