v4

.eslintrc.js

@@ -0,0 +1,50 @@
+module.exports = {
+	env: {
+		commonjs: true,
+		es2021: true,
+		node: true
+	},
+	extends: 'eslint:recommended',
+	parserOptions: {
+		ecmaVersion: 12
+	},
+	rules: {
+		// Use tabs for indentation and require 'case' in switch to be indented 1 level (default 0)
+		indent: ['error', 'tab', {SwitchCase: 1}],
+		// Single quotes for strings
+		quotes: ['error', 'single'],
+		// Always require semicolons
+		semi: ['error', 'always'],
+		// Don't use 'var'
+		'no-var': 'error',
+		// Only use quotes in object literal keys as needed
+		'quote-props': ['error', 'as-needed'],
+		// Don't allow trailing spaces after a line
+		'no-trailing-spaces': 'error',
+		// Require spaces before and after keywords (like "if")
+		'keyword-spacing': 'error',
+		// Don't allow unused variables, but allow unused function args (e.g. in callbacks) and global vars
+		'no-unused-vars': ['error', {vars: 'local', args: 'none', varsIgnorePattern: '^_'}],
+		// Require using dot notation (obj.prop instead of obj['prop']) where possible
+		'dot-notation': 'error',
+		// Don't use spaces before parens in anonymous or named functions
+		'space-before-function-paren': ['error', {anonymous: 'never', named: 'never', asyncArrow: 'always'}]
+
+		// We will NOT be using eqeqeq for a few reasons:
+		//  1. I would have to go through and check every single `==` to make sure that it's not depending on loose equality checks.
+		//  2. I'm only using ESLint to enforce style, not actual differences in functionality. ==/=== is not merely a style choice.
+		//       Yes, I know that 'no-var' is actually enforcing a difference in functionality, but in practice nobody uses
+		//       (or even knows about) var's hoisting functionality, so at this point it's effectively a style choice.
+		//  3. A lot of the time, you actually *want* loose equality checks, especially when interacting with a web server
+		//       (as HTTP as no concept of anything but strings). Yes, most of our interaction is JSON, but not all. And even then,
+		//       not all JSON actually serializes numbers as numbers.
+		//  4. `==` is really nowhere near as dangerous as memes would lead you to believe, if you know what you're doing.
+		//  5. If the idea behind enforcing `===` is to prevent inexperienced developers from unwittingly introducing bugs
+		//       via loose quality checks, in my opinion it could be just as harmful to instruct a code quality tool to
+		//       naively demand that all `==` become `===`. If a developer were to build code that works, but upon opening
+		//       a pull request they see that ESLint demands they use `===` instead, they might just click "fix" and resubmit,
+		//       expecting the code quality tool to know what it's doing. But it *doesn't* know what it's doing, since it's
+		//       just blindly alerting when it sees `==`. The change in functionality from `==` to `===` could very well
+		//       introduce a bug by itself.
+	}
+};

.github/workflows/eslint.yml

@@ -0,0 +1,31 @@
+name: ESLint
+
+on: [push, pull_request]
+
+jobs:
+    lint:
+        runs-on: ubuntu-latest
+
+        # Run for external PRs, but not on our own internal PRs as they'll be run by the push to the branch.
+        if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != 'DoctorMcKay/node-steamcommunity'
+
+        strategy:
+            matrix:
+                node-version: [10.x]
+
+        steps:
+            - uses: actions/checkout@v1
+              with:
+                  fetch-depth: 1
+
+            - name: Use Node.js ${{ matrix.node-version }}
+              uses: actions/setup-node@v1
+              with:
+                  node-version: ${{ matrix.node-version }}
+
+            - name: npm install
+              working-directory: .
+              run: npm install --ignore-scripts
+
+            - name: Run ESLint
+              run: npm run lint

.gitignore

@@ -1,5 +1,6 @@
 node_modules/*
 test.js
+dev/
 
 # Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and WebStorm
 # Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839

classes/CConfirmation.js

@@ -1,4 +1,6 @@
-var SteamCommunity = require('../index.js');
+const StdLib = require('@doctormckay/stdlib');
+
+const SteamCommunity = require('../index.js');
 
 module.exports = CConfirmation;
 
@@ -18,20 +20,33 @@ function CConfirmation(community, data) {
 	this.offerID = this.type == SteamCommunity.ConfirmationType.Trade ? this.creator : null;
 }
 
+/**
+ * @param {number} time
+ * @param {string} key
+ * @param {function} [callback]
+ * @return Promise<{offerID: number}>
+ */
 CConfirmation.prototype.getOfferID = function(time, key, callback) {
-	if (this.type && this.creator) {
-		if (this.type != SteamCommunity.ConfirmationType.Trade) {
-			callback(new Error('Not a trade confirmation'));
-			return;
-		}
+	return StdLib.Promises.callbackPromise(['offerID'], null, false, async (resolve, reject) => {
+		if (this.type && this.creator) {
+			if (this.type != SteamCommunity.ConfirmationType.Trade) {
+				return reject(new Error('Not a trade confirmation'));
+			}
 
-		callback(null, this.creator);
-		return;
-	}
+			return resolve({offerID: this.creator});
+		}
 
-	this._community.getConfirmationOfferID(this.id, time, key, callback);
+		return await this._community.getConfirmationOfferID(this.id, time, key, callback);
+	});
 };
 
+/**
+ * @param {number} time
+ * @param {string} key
+ * @param {boolean} accept
+ * @param {function} [callback]
+ * @return Promise<void>
+ */
 CConfirmation.prototype.respond = function(time, key, accept, callback) {
-	this._community.respondToConfirmation(this.id, this.key, time, key, accept, callback);
+	return this._community.respondToConfirmation(this.id, this.key, time, key, accept, callback);
 };

classes/CEconItem.js

@@ -1,14 +1,11 @@
 module.exports = CEconItem;
 
 function CEconItem(item, description, contextID) {
-	var thing;
-	for (thing in item) {
-		if (item.hasOwnProperty(thing)) {
-			this[thing] = item[thing];
-		}
+	for (let thing in item) {
+		this[thing] = item[thing];
 	}
 
-	var isCurrency = !!(this.is_currency || this.currency) || typeof this.currencyid !== 'undefined'; // I don't want to put this on the object yet; it's nice to have the ids at the top of printed output
+	let isCurrency = !!(this.is_currency || this.currency) || typeof this.currencyid !== 'undefined'; // I don't want to put this on the object yet; it's nice to have the ids at the top of printed output
 
 	if (isCurrency) {
 		this.currencyid = this.id = (this.id || this.currencyid);
@@ -27,10 +24,8 @@ function CEconItem(item, description, contextID) {
 			description = description[this.classid + '_' + this.instanceid];
 		}
 
-		for (thing in description) {
-			if (description.hasOwnProperty(thing)) {
-				this[thing] = description[thing];
-			}
+		for (let thing in description) {
+			this[thing] = description[thing];
 		}
 	}
 
@@ -49,20 +44,18 @@ function CEconItem(item, description, contextID) {
 
 	// Restore old property names of tags
 	if (this.tags) {
-		this.tags = this.tags.map(function(tag) {
-			return {
-				"internal_name": tag.internal_name,
-				"name": tag.localized_tag_name || tag.name,
-				"category": tag.category,
-				"color": tag.color || "",
-				"category_name": tag.localized_category_name || tag.category_name
-			};
-		});
+		this.tags = this.tags.map((tag) => ({
+			internal_name: tag.internal_name,
+			name: tag.localized_tag_name || tag.name,
+			category: tag.category,
+			color: tag.color || '',
+			category_name: tag.localized_category_name || tag.category_name
+		}));
 	}
 
 	// Restore market_fee_app, if applicable
-	var match;
-	if (this.appid == 753 && this.contextid == 6 && this.market_hash_name && (match = this.market_hash_name.match(/^(\d+)\-/))) {
+	let match;
+	if (this.appid == 753 && this.contextid == 6 && this.market_hash_name && (match = this.market_hash_name.match(/^(\d+)-/))) {
 		this.market_fee_app = parseInt(match[1], 10);
 	}
 
@@ -82,7 +75,7 @@ function CEconItem(item, description, contextID) {
 		this.cache_expiration = this.item_expiration;
 	}
 
-	if (this.actions === "") {
+	if (this.actions === '') {
 		this.actions = [];
 	}
 
@@ -94,23 +87,23 @@ function CEconItem(item, description, contextID) {
 }
 
 CEconItem.prototype.getImageURL = function() {
-	return "https://steamcommunity-a.akamaihd.net/economy/image/" + this.icon_url + "/";
+	return 'https://steamcommunity-a.akamaihd.net/economy/image/' + this.icon_url + '/';
 };
 
 CEconItem.prototype.getLargeImageURL = function() {
-	if(!this.icon_url_large) {
+	if (!this.icon_url_large) {
 		return this.getImageURL();
 	}
 
-	return "https://steamcommunity-a.akamaihd.net/economy/image/" + this.icon_url_large + "/";
+	return 'https://steamcommunity-a.akamaihd.net/economy/image/' + this.icon_url_large + '/';
 };
 
 CEconItem.prototype.getTag = function(category) {
 	if (!this.tags) {
 		return null;
 	}
 
-	for (var i = 0; i < this.tags.length; i++) {
+	for (let i = 0; i < this.tags.length; i++) {
 		if (this.tags[i].category == category) {
 			return this.tags[i];
 		}