Fix resolving vanity for private profiles returning error#315
Open
3urobeat wants to merge 1 commit intoDoctorMcKay:masterfrom
Open
Fix resolving vanity for private profiles returning error#3153urobeat wants to merge 1 commit intoDoctorMcKay:masterfrom
3urobeat wants to merge 1 commit intoDoctorMcKay:masterfrom
Conversation
Contributor
Author
|
Hey, sorry for bumping, but it would be cool if you could review this PR as it fixes bugs present in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #313 (again)
Steam does not provide a
customURLkey in the XML data for private profiles which is something I did not expect when working on the previous PR.To keep support for providing
/profiles/steamID64links I have added an if check that only parses the URL param as a fallback option.If a
/profiles/steamID64link was provided to a private profile there is nothing we can do so I am returning an empty string.I hope there is no other oversight hidden in this function now