feat: Extend existing sharedfiles implementation#344
Open
3urobeat wants to merge 6 commits intoDoctorMcKay:masterfrom
Open
feat: Extend existing sharedfiles implementation#3443urobeat wants to merge 6 commits intoDoctorMcKay:masterfrom
3urobeat wants to merge 6 commits intoDoctorMcKay:masterfrom
Conversation
…clearly from workshop item subscribe functions
Contributor
Author
|
Added a patch (to this very stale PR, please review :( ) that fixes Greenlight items are workshop items that can be voted into a game, e.g. CS skins. These items use a different container to list the voting buttons, hence causing the previous implementation to fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR extends the existing sharedfiles implementation to...:
Workshop Items are also listed as sharedfiles on the SteamCommunity (see the CS2 Insertion2 map for example), which is why I added support to the existing sharedfiles class, instead of adding a new one.
This PR might display conflicts later on as it is based on the master branch and not on the fixes of my two other sharedfiles PRs (
#315ļ). I'll address them gladly when it is time.Thanks!