Issue #7: Added redeemGameKey method#8
Open
saitho wants to merge 2 commits intoDoctorMcKay:masterfrom
saitho:master
Open
Issue #7: Added redeemGameKey method#8saitho wants to merge 2 commits intoDoctorMcKay:masterfrom saitho:master
saitho wants to merge 2 commits intoDoctorMcKay:masterfrom
saitho:master
Conversation
Closed
Revadike
suggested changes
Oct 12, 2021
Revadike
left a comment
Revadike
left a comment
There was a problem hiding this comment.
There are other styling issues (using spaces, not tabs).
| }); | ||
| }; | ||
|
|
||
| SteamStore.prototype.redeemGameKey = function(code, callback) { |
There was a problem hiding this comment.
Suggested change
| SteamStore.prototype.redeemGameKey = function(code, callback) { | |
| SteamStore.prototype.redeemSteamKey = function(code, callback) { |
or simply
Suggested change
| SteamStore.prototype.redeemGameKey = function(code, callback) { | |
| SteamStore.prototype.redeemKey = function(code, callback) { |
Steam keys don't only activate games, they activate any type of app. Technically, steam keys redeem steam packages.
Comment on lines
+164
to
+165
| ### redeemGameKey(gameKey[, callback]) | ||
| - `gameKey` - The Steam game key you want to redeem |
There was a problem hiding this comment.
Suggested change
| ### redeemGameKey(gameKey[, callback]) | |
| - `gameKey` - The Steam game key you want to redeem | |
| ### redeemSteamKey(steamKey[, callback]) | |
| - `steamKey` - The Steam activation key you want to redeem |
or simply
Suggested change
| ### redeemGameKey(gameKey[, callback]) | |
| - `gameKey` - The Steam game key you want to redeem | |
| ### redeemKey(key[, callback]) | |
| - `key` - The Steam activation key you want to redeem |
Steam keys don't only activate games, they activate any type of app. Technically, steam keys redeem steam packages.
|
@DoctorMcKay Why wasn't this merged in some way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds redeemGameKey functionality described in #7.
Example usage: https://gist.github.com/saitho/a5466402b4bc1c7b2ec431c350f08567