Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.22
22.22.1
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ If your application has significant keyboard usage, consider this when interpret

## Development

Development requires Node.js >= 22.18.0 (see `.node-version`).
Development requires Node.js >= 22.22.1 (see `.node-version`).

```bash
npm install
Expand Down
119 changes: 72 additions & 47 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"@types/react": "19.2.14",
"happy-dom": "20.9.0",
"husky": "9.1.7",
"lint-staged": "16.4.0",
"lint-staged": "17.0.2",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Upgrading to lint-staged 17 raises the minimum development Node.js version to >=22.22.1. This repo still advertises >=22.18.0 in README.md, and .npmrc has engine-strict=true, so contributors following the documented minimum will now hit npm ci failures before they can work locally. Please update the repo’s declared/dev Node baseline (and ideally pin .node-version to 22.22.1+) in the same PR, or keep lint-staged on v16.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, addressed in bba5ddc.

lint-staged@17 raises its required Node engine to >=22.22.1.

Changes:

  • README.md — documented minimum bumped to >=22.22.1
  • .node-version — pinned to 22.22.1 (was 22.22, which left the patch ambiguous for nvm users)

Verified locally with engine-strict=true: npm ci, npm run build, and npm test all pass.

I'm going to re-assign this PR so someone else since I modified the original work.

"npm-run-all2": "8.0.4",
"react": "19.2.5",
"react-dom": "19.2.5",
Expand Down
Loading