Open
Conversation
Open
Moved AcmPartRef from BOM to Mechanical namespace and updated references accordingly. Added the GraphicsType enum in ProxyGraphics to represent various proxy graphic element types. No functional changes to AcmPartRef implementation.
This was referenced Apr 3, 2026
Open
Introduced infrastructure for reading and storing proxy graphics in entities, including a new ProxyGeometries property and parsing logic. Updated DwgObjectReader and CadEntityTemplate to handle proxy graphics data. Refactored related classes to require ObjectName implementation and improved placeholder/template handling. These changes enable future support for custom and third-party DWG objects with proxy graphics.
Split proxy geometry types into individual classes implementing IProxyGeometry. Simplified GraphicsType enum and rewrote ProxyGeometry to parse and return strongly-typed geometry objects. Removed monolithic parsing logic in favor of modular, extensible design. Parsing implemented for Circle, Extents, and Polyline; other types throw NotImplementedException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Short description about this PR
Tasks done in this PR
Related Issues / Pull Requests
Notes for reviewer