Skip to content

Added ability to override css styling for hints#14

Open
petertriho wants to merge 3 commits into
DominicVonk:masterfrom
petertriho:style-override
Open

Added ability to override css styling for hints#14
petertriho wants to merge 3 commits into
DominicVonk:masterfrom
petertriho:style-override

Conversation

@petertriho

Copy link
Copy Markdown

Hi @DominicVonk,

Love the extension!

I've add a commit to override the styling of hints (would like to modify things like font size, weight, style, etc)

I've never worked with vscode extensions before so I'm not sure if this is the correct/preferred way of doing it.

Thanks,
Peter

@DominicVonk

Copy link
Copy Markdown
Owner

Hi @petertriho,

Thank you for the contribution, and I'm glad to hear you love the extension.

This is a good beginning, I will add this with a possibility to change them also per theme, because it could happen you want to change it per theme.

I will add this to the shortlist, to be released this week.

@DominicVonk DominicVonk linked an issue Sep 1, 2020 that may be closed by this pull request
@petertriho

Copy link
Copy Markdown
Author

@DominicVonk

I've added per theme overrides. Usage example (in settings.json):

{
	"parameterHints.defaultStyles": {
		"fontStyle": "normal"
	},
	"parameterHints.themeStyles": {
		"GitHub Dark": {
			"fontStyle": "bold"
		}
	}
}

@DominicVonk

Copy link
Copy Markdown
Owner

Thank you, I will implement the feature this week, there is a more general way for per theme overriding, I should have mentioned it before. But I will add this today. Thank you very much. Please join the issue board. To view the progress.

@DominicVonk

Copy link
Copy Markdown
Owner

@petertriho

Copy link
Copy Markdown
Author

Sounds good! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add generic style override, theme based and generic.

2 participants