[bug fix] Clear unused canvases to avoid memory leak. #191
Open
hedgerwang wants to merge 3 commits intoDonaldcwl:masterfrom
Open
[bug fix] Clear unused canvases to avoid memory leak. #191hedgerwang wants to merge 3 commits intoDonaldcwl:masterfrom
hedgerwang wants to merge 3 commits intoDonaldcwl:masterfrom
Conversation
Author
|
cc @Donaldcwl |
hedgerwang
changed the title
hedgerwang
changed the title
The function `cleanupCanvasMemory` does not really cleans up the memory when the canvas size is set as `0`. The right way to clean up the memory is to size the size to `1` instead.
hedgerwang
commented
May 8, 2023
| canvas.width = 0; | ||
| canvas.width = 1; | ||
| // eslint-disable-next-line no-param-reassign | ||
| canvas.height = 0; |
Author
There was a problem hiding this comment.
Setting the width or height to 0 doesn't actually free up memory. Instead, it makes the canvas context unavailable to the canvas, while the associated pixel data remains preserved in memory. The correct method for clearing memory is to set the size to 1.
Refer to this blog post for more information: https://pqina.nl/blog/total-canvas-memory-use-exceeds-the-maximum-limit/
|
Hi, can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolved the issue where some canvases were not cleared properly, and it might result in reaching the limit of maximum canvas memory usage when the client attempted to compress multiple images.