Container detail view + exec into shell (#8)#19
Merged
Conversation
- ContainerDetail model (image/command/env/ports/mounts/started) + containerExecCommand helper - ContainerEngine.detail(id:) via ContainerClient.get; SDKContainerEngine maps the config - AppState.detail + execShell (opens an interactive shell in Terminal via osascript) - DetailWindow: inspect fields + toolbar Shell/Logs; opened from a row 'Details' action - Tests: exec-command building + formatBytes (30 tests pass) Closes #8
…interpolation Security review flagged command injection: the container id is interpolated into an AppleScript 'do script'. Add isValidContainerName allowlist (^[A-Za-z0-9][A-Za-z0-9_.-]*$) and refuse anything else in ContainerShell.openShell, with a test covering injection attempts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a per-container Details window (row → info icon) and exec into shell.
ContainerDetail(image, command, env, ports, mounts, started) +containerExecCommandhelper.ContainerEngine.detail(id:)viaContainerClient.get;SDKContainerEnginemaps the config.AppState.detail+execShell— opens an interactive shell in Terminal (container exec -it <id> shviaosascript).DetailWindow: inspect fields + a toolbar with Shell and Logs.Tests: exec-command building +
formatBytes(30 ConsaiCore tests pass).swift buildclean.Closes #8