Skip to content

Improvements during debug session at Inria testbed#216

Open
geonnave wants to merge 2 commits intoDotBots:mainfrom
geonnave:debugging-in-arena-04mar2026
Open

Improvements during debug session at Inria testbed#216
geonnave wants to merge 2 commits intoDotBots:mainfrom
geonnave:debugging-in-arena-04mar2026

Conversation

@geonnave
Copy link
Contributor

@geonnave geonnave commented Mar 4, 2026

No description provided.

@geonnave geonnave force-pushed the debugging-in-arena-04mar2026 branch from d14712b to 4c1ff8a Compare March 4, 2026 16:35
@geonnave geonnave force-pushed the debugging-in-arena-04mar2026 branch from 4c1ff8a to 5f4c06d Compare March 4, 2026 16:39
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 69.23077% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.76%. Comparing base (05e6313) to head (5f4c06d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dotbot/examples/stop.py 40.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   68.84%   68.76%   -0.08%     
==========================================
  Files          40       42       +2     
  Lines        3739     3768      +29     
==========================================
+ Hits         2574     2591      +17     
- Misses       1165     1177      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -0,0 +1,21 @@
from dotbot.examples.charging_station.charging_station import DT as DT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about keeping this module empty and modify the import in the corresponding test module? I would find it more convenient as it's only a one liner, even if you have to do import from dotbot.examples.charging_station.charging_station import ....

@@ -0,0 +1,44 @@
import asyncio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the use case of this example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: when we run any of the examples in a real robot, then when (1) when we stop the example with ctrl+c or (2) the example script crashes, the robots just keep running like crazy. This stop commands make them stop, without having to call swamit stop (and then swarmit start again). Technically we could just use swarmit stop, but right now it takes like 5 seconds or more, which is annoying from a development experience PoV.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but could it be done in the example script directly?
in a "catch KeyboardInterrup" block, send the empty waypoint and return

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants