fix(rank): remove invalid AttachmentBuilder.build() crashing /rank info#106
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(rank): remove invalid AttachmentBuilder.build() crashing /rank info#106cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
discord.js v14 AttachmentBuilder has no .build() method. Calling it throws TypeError and breaks every /rank info invocation after the card is generated. Co-authored-by: zVapor_ <contact@zvapor.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Every
/rank infoinvocation crashed after the rank card was generated with:TypeError: (intermediate value).build is not a functionUsers could never view rank cards.
Root cause
rank.jscallednew AttachmentBuilder(data, { name: "rank.png" }).build(), but discord.js v14'sAttachmentBuilderhas no.build()method (unlike canvacord'sRank.build()).Fix
Pass the
AttachmentBuilderinstance directly in thefilesarray.Validation
npm test(39 tests, including newtests/rank-attachment.test.js)AttachmentBuilder(...).build()before the fix