fix(events): remove duplicate interaction dispatch after handler restore#115
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(events): remove duplicate interaction dispatch after handler restore#115cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Restoring per-module Guild event registration (c430893) re-enabled interactionCreate.js and components.js alongside the validations chain. Both paths executed the same slash commands, dev commands, and UI components, causing double DB writes (economy corruption) and InteractionAlreadyReplied errors. Delete the duplicate Guild handlers, route command-type toggles through validators, and guard all validation handlers against re-entry when an interaction was already handled. Co-authored-by: zVapor_ <contact@zvapor.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
After
c430893restored per-module Guild event registration, slash commands, dev commands, and UI components were dispatched twice on every interaction:src/events/Guild/interactionCreate.js/components.js(re-enabled)src/events/validations/*(always active)Concrete trigger: User runs
/economy→ Create,/deposit,/rob, or clicks a setup button. Both handlers callrun(), causing duplicate DB writes (economy balance corruption), duplicate account creation/deletion, andInteractionAlreadyRepliederrors.Root cause
The broken folder-scoped events handler (pre-
c430893) registered Guild modules on a non-existent"Guild"event, so only the validations chain ran. Fixing registration brought back the legacy Guild dispatch path without removing the validations path.Fix
interactionCreate.jsandcomponents.jsGuild handlersconfig.handler.commands.*toggles into the relevant validatorsinteraction.replied || interaction.deferredguards to all validators that callrun()tests/interaction-dispatch.test.jsValidation
npm test— 40/40 passing