fix(events): prevent double slash/component execution on interactionCreate#125
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(events): prevent double slash/component execution on interactionCreate#125cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…reate Validators and Guild handlers each registered separate interactionCreate listeners. Both could run the same command before either replied, causing duplicate economy mutations, double replies, and cooldown bypass. Chain validators, components, and interactionCreate in one sequential listener. Validators now gate permissions only; Guild handlers execute once. Co-authored-by: zVapor_ <contact@zvapor.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Slash commands, dev commands, buttons, select menus, and modals were executed twice on every interaction. Validators (
src/events/validations/*) and Guild handlers (interactionCreate.js,components.js) each registered separateclient.on("interactionCreate")listeners. Because Discord.js invokes listeners concurrently, both paths could passinteraction.repliedchecks before either replied.Concrete trigger: A user runs
/deposit amount:100. BothchatInputCommandValidatorandGuild/interactionCreatecallcommand.run(), applying two deposits and attempting two replies (second throws or is swallowed).Same pattern affected
/rob(economy corruption), ticket buttons, and dev commands like/eval.Root cause
The events handler regression fix restored per-module Guild listeners without deduplicating the existing validations listener chain. The prior
replied/deferredguards only worked within a single listener, not across parallel listeners.Fix
interactionCreatelistener that runs validators →components.run→interactionCreate.runsequentially.interactionCreate.js/components.jsas separate listeners.contextMenuCommandValidator(no duplicate Guild handler exists).Validation
tests/interaction-single-listener.test.jsregression tests.tests/events-handler-shape.test.js.npm test— 40/40 passing.