fix(events): remove duplicate slash/component execution handlers#129
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(events): remove duplicate slash/component execution handlers#129cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Guild/interactionCreate.js and Guild/components.js both called command.run() for the same interactions as the validations/ chain. After the events handler regression fix restored per-module registration, every slash command and button ran twice — causing double economy writes (/beg), duplicate ticket closes, and InteractionAlreadyReplied errors. Validators are now the sole execution path, with replied/deferred guards. Co-authored-by: zVapor_ <contact@zvapor.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Every slash command and component button was executed twice per user interaction. This caused:
/begapplied two random wallet changes per invocationticket-closescheduled two channel deletes and sent two DMsRoot cause
The events handler regression fix (PR #71) restored per-module
client.on(eventModule.event, …)registration forGuild/interactionCreate.jsandGuild/components.js. Those legacy handlers callcommand.run()/component.run()for the same interactions that thevalidations/chain already handles, so both paths fired on every interaction.Fix
src/events/Guild/interactionCreate.jsandsrc/events/Guild/components.js(validators are the sole execution path)interaction.replied || interaction.deferredguards to all six validators as a safety belttests/interaction-single-execution.test.jsregression coverageValidation
npm test— 39/39 passing