Fix makeDinnerTaskGroup code example#42
Open
ryansobol wants to merge 2 commits intoDougGregor:structured-concurrencyfrom
Open
Fix makeDinnerTaskGroup code example#42ryansobol wants to merge 2 commits intoDougGregor:structured-concurrencyfrom
ryansobol wants to merge 2 commits intoDougGregor:structured-concurrencyfrom
Conversation
The `makeDinnerTaskGroup()` code example has a couple of potential issues: 1. The `withTaskGroup()` function doesn't seem to be defined or mentioned anywhere else in this proposal. Do you mean `Task.withGroup`? 1. There are no `try await` keywords prepended to the expression initializing the task group. Was this an accidental omission? 1. There is no `return` keyword prepended to the expression either. I'm not sure if this is needed or not; see my [previous pull request](DougGregor#41).
xAlien95
reviewed
Dec 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
makeDinnerTaskGroup()code example has a couple of potential issues:withTaskGroup()function doesn't seem to be defined or mentioned anywhere else in this proposal. Do you meanTask.withGroup?try awaitkeywords prepended to the expression initializing the task group. Was this an accidental omission?returnkeyword prepended to the expression either. I'm not sure if this is needed or not; see my previous pull request.DinnerChildTask.self. Should it beDinnerChild.self?whileloop.