Skip to content

Double click row #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshunrau merged 2 commits into from
Feb 26, 2026
Merged

Double click row #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
164714e
feat: make double click on row navigate to subjects page
david-roper Feb 26, 2026
e4a85e3
chore: update lock file and workspace libui catalog
david-roper Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/web/src/routes/_app/datahub/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,9 @@ const Toggles: React.FC<{ table: TanstackTable.Table<Subject> }> = ({ table }) =

const MasterDataTable: React.FC<{
data: Subject[];
onRowDoubleClick: (subject: Subject) => void;
onSelect: (subject: Subject) => void;
}> = ({ data, onSelect }) => {
}> = ({ data, onRowDoubleClick, onSelect }) => {
const { t } = useTranslation();
const subjectIdDisplaySetting = useAppStore((store) => store.currentGroup?.settings.subjectIdDisplayLength);

Expand Down Expand Up @@ -373,6 +374,7 @@ const MasterDataTable: React.FC<{
}
]}
togglesComponent={Toggles}
onRowDoubleClick={onRowDoubleClick}
onSearchChange={(value, table) => {
const subjectIdColumn = table.getColumn('subjectId')!;
subjectIdColumn.setFilterValue(value);
Expand Down Expand Up @@ -400,6 +402,9 @@ const RouteComponent = () => {
<div className="flex grow flex-col">
<MasterDataTable
data={data}
onRowDoubleClick={(subject) => {
void navigate({ to: `./${subject.id}/table` });
}}
onSelect={(subject) => {
void navigate({ to: `./${subject.id}/table` });
}}
Expand Down
26 changes: 13 additions & 13 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ catalog:
'@douglasneuroinformatics/libjs': ^3.2.0
'@douglasneuroinformatics/libpasswd': 'latest'
'@douglasneuroinformatics/libstats': 'latest'
'@douglasneuroinformatics/libui': ^6.1.3
'@douglasneuroinformatics/libui': ^6.2.0
'@douglasneuroinformatics/libui-form-types': 'latest'
'@microsoft/api-extractor': '^7.47.6'
'@prisma/client': '^6.9.0'
Expand Down