#2 again: Cannot read property of _value of undefined#6
Open
claudiordgz wants to merge 1 commit intoDrewML:masterfrom
Open
#2 again: Cannot read property of _value of undefined#6claudiordgz wants to merge 1 commit intoDrewML:masterfrom
claudiordgz wants to merge 1 commit intoDrewML:masterfrom
Conversation
Author
|
just saw that #5 is doing some form of file renaming manipulation, looks like a better approach than this one |
DrewML
reviewed
Jul 2, 2018
| // ConcatenatedModule | ||
| // ExternalModule | ||
| // ContextModule | ||
| if (mod._source === null) return; |
Owner
There was a problem hiding this comment.
Can we just keep this fix in this PR, and then I'll merge #5 (want to make sure @bv-loveholidays gets credit for doing that part)? Then I can merge + release both
There was a problem hiding this comment.
oh oops, I don't know how I missed this.
Owner
|
Thanks @claudiordgz! Appreciate the PR. Just that one comment 😃 |
|
so, is this ready to mrege? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
I'm compiling a TypeScript library to be used on Node Applications (Lambdas). I tried using this plugin but couldn't get past the
cannot read property of _value of undefinedproblem.Turns out
_sourcecomes null for more thanMultiModule. The first one I found wasConcatenatedModule.I kept digging and found that
_sourcealso comes null for everyone on this list (but not limited to tho):I tried just doing
if (mod._source === null) return;with great success, all my TS code appeared in a single folder as javascript, but with the.tsfile extension.So I added the following to handle this:
This might not be desired/wanted I just did it because it was pretty simple, so no hard feelings if it's a non-issue and you close it.