fix: Set correct installer package name for Shizuku #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apps installed via Shizuku and Root installers were not being marked as "App installed from (D)roid-ify" in system settings because the wrong package name was passed to the -i flag. ShizukuInstaller was using the installed app's package name instead of Droid-ify's package name. RootInstaller was missing the -i flag entirely. Now both installers use context.packageName to correctly identify Droid-ify as the installer, so `pm list packages -i` returns `installer=com.looker.droidify`. Fixes Droid-ify#1044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps installed via Shizuku and Root installers were not being marked as "App installed from (D)roid-ify" in system settings because the wrong package name was passed to the -i flag.
ShizukuInstaller was using the installed app's package name instead of Droid-ify's package name. RootInstaller was missing the -i flag entirely.
Now both installers use context.packageName to correctly identify Droid-ify as the installer, so
pm list packages -ireturnsinstaller=com.looker.droidify.Fixes #1044